[Fiber] fix useId tracking on replay - #35518
Merged
gnoff merged 1 commit intoJan 16, 2026
Merged
Conversation
gnoff
requested review from
acdlite and
sebmarkbage
and removed request for
sebmarkbage
January 15, 2026 17:53
github-actions
Bot
added
the
React Core Team
sebmarkbage
approved these changes
Jan 15, 2026
|
Comparing: bb8a76c...5f9a809 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
When Fiber replays work after suspending and resolving in a microtask it stripped the Forked flag from Fibers because this flag type was not considered a Static flag. The Forked nature of a Fiber is not render dependent and should persist after unwinding work. By making this change the replay correctly generates the necessary tree context.
gnoff
force-pushed
the
jstory/fix-hydration-on-immediate-suspend-useid
branch
from
January 16, 2026 01:22
e64b9a0 to
5f9a809
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
When Fiber replays work after suspending and resolving in a microtask it stripped the Forked flag from Fibers because this flag type was not considered a Static flag. The Forked nature of a Fiber is not render dependent and should persist after unwinding work. By making this change the replay correctly generates the necessary tree context. DiffTrain build for [f0fbb0d](f0fbb0d)
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
When Fiber replays work after suspending and resolving in a microtask it stripped the Forked flag from Fibers because this flag type was not considered a Static flag. The Forked nature of a Fiber is not render dependent and should persist after unwinding work. By making this change the replay correctly generates the necessary tree context. DiffTrain build for [f0fbb0d](f0fbb0d)
Collaborator
Author
|
Fixes #35399 I think |
This was referenced Jan 16, 2026
guilhermeKodama
added a commit
to guilhermeKodama/kodama-labs
that referenced
this pull request
Jun 10, 2026
…tch (#36) Next 16.1.x vendors React 19.3.0-canary-f93b9fd4-20251217, which has a Fiber bug where useId tree context is mistracked when a component suspends and replays during hydration (react/react#35518). Radix Dialog/Sheet derives aria-controls from useId, so the SheetTrigger in mobile-top-bar.tsx hydrated with a different id than the server HTML, producing hydration mismatch warnings on every page. Next 16.2.0+ vendors React 19.3.0-canary-3f0b9e61-20260317 which includes the fix (vercel/next.js#88649). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
guilhermeKodama
added a commit
to guilhermeKodama/kodama-labs
that referenced
this pull request
Jun 11, 2026
Next 16.x before 16.2.0 bundles a React canary with a Fiber bug where the useId tree context is tracked incorrectly when a component suspends and is replayed during hydration (react/react#35518), causing hydration mismatches on useId-derived attributes (e.g. aria-controls in Radix components). The fix landed in Next 16.2.0+ via the vendored React upgrade (vercel/next.js#88649); sentinel was already bumped to 16.2.9 for the same reason. Bump next and eslint-config-next from 16.1.6 (capital, kodamalabs) and 16.0.1 (docs) to 16.2.9. next-env.d.ts files were regenerated by the new version. Typecheck, lint and build validated for all three apps. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
guilhermeKodama
added a commit
to guilhermeKodama/kodama-labs
that referenced
this pull request
Aug 5, 2026
Next 16.x before 16.2.0 bundles a React canary with a Fiber bug where the useId tree context is tracked incorrectly when a component suspends and is replayed during hydration (react/react#35518), causing hydration mismatches on useId-derived attributes (e.g. aria-controls in Radix components). The fix landed in Next 16.2.0+ via the vendored React upgrade (vercel/next.js#88649); sentinel was already bumped to 16.2.9 for the same reason. Bump next and eslint-config-next from 16.1.6 (capital, kodamalabs) and 16.0.1 (docs) to 16.2.9. next-env.d.ts files were regenerated by the new version. Typecheck, lint and build validated for all three apps. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
guilhermeKodama
added a commit
to guilhermeKodama/kodama-labs
that referenced
this pull request
Aug 5, 2026
Next 16.1.x vendors React 19.3.0-canary-f93b9fd4-20251217, which has a Fiber bug where useId tree context is mistracked when a component suspends and replays during hydration (react/react#35518). Radix Dialog/Sheet derives aria-controls from useId, so the SheetTrigger in mobile-top-bar.tsx hydrated with a different id than the server HTML, producing hydration mismatch warnings on every page. Next 16.2.0+ vendors React 19.3.0-canary-3f0b9e61-20260317 which includes the fix (vercel/next.js#88649). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Fiber replays work after suspending and resolving in a microtask it stripped the Forked flag from Fibers because this flag type was not considered a Static flag. The Forked nature of a Fiber is not render dependent and should persist after unwinding work. By making this change the replay correctly generates the necessary tree context.