Added check to deduplicate function type warning calls on each compon… - #11120
Added check to deduplicate function type warning calls on each compon…#11120gaearon merged 4 commits into
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hmm, I've completed the CLA. |
|
Deploy preview ready! Built with commit 5852b59 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Can you please test it too? You can take the existing test for it, expand it to render two times and in two places, and then verify that we only saw 2 logs (rather than 4). |
|
Sure, I'll update it soon |
…duplicated correctly by component type
|
I've added test checking deduplication of warning. |
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
I don't think this tests deduplication. You'd need to render twice to verify it works.
… React child' warning so it will check against rerendering component now
|
Yeah, my bad, sorry. I've added rendering of component twice to the test. |
|
Looks great. Thanks! |
react#11120) * Added check to deduplicate function type warning calls on each component type * Added test to check that 'function type as React child' warning is deduplicated correctly by component type * Ran prettier on added code * Modified test checking deduplication of 'Functions are not valid as a React child' warning so it will check against rerendering component now
4 participants
Hey, I've added check to avoid duplication of messages 'Functions are not valid as React child...' for same component type.
Also, this is my first PR in React, yay.