[NavigationExperimental] Kill NavigationAnimatedView

[jmurzy]

NavigationAnimatedView is deprecated. Use NavigationTransitioner.

As discussed in #8262, #8189.

[ghost]

By analyzing the blame information on this pull request, we identified @hedgerwang and @ericvicenti to be potential reviewers.

[ide]

@ericvicenti can you take care of this? I'm thinking there might be callers of NavigationAnimatedView still within FB-internal code and deleting the file will break internal apps/tests.

[ericvicenti]

@ide, you read my mind!

[ericvicenti]

@facebook-github-bot import

[ghost]

Thanks for importing. If you are an FB employee go to Phabricator to review.

[jmurzy]

@ericvicenti Also, there is a bug in NavigationTransitioner that needs to be fixed before we completely get rid of NavigationAnimatedView.

/cc @hedgerwang

🍺

[tpisto]

NavigationTransitioner is very very slow compared to previous NavigationAnimatedView. With NavigationAnimatedView the transition was instant, but now with NavigationTransitioner the same change takes like 3 seconds.

[ericvicenti]

@tpisto, I don't think NavigationTransitioner is inherently much slower, but it depends on how it is used. Could you post a code snippet that demonstrates how slow it is now?

[tpisto]

Hi! Thank you for quick reply. I am using this solution:

https://github.com/jlyman/RN-NavigationExperimental-Redux-Example/blob/0.27/app/containers/AppContainer.js

But before I used AnimatedView. And with AnimatedView animations go like this:

After updating to 0.30.0 and switching to Transitioner the animations go like this (not that I click the arrow down when the cursor moves slightly - so making many seconds the transition to happen):

There are no any additional changes to code - just 0.29.2 -> 0.30.0 and AnimatedView -> Transitioner. (And Transitioner seems to need render instead of renderScene)

[arronmabrey]

@tpisto Is this still an issue you're facing or were you able to figure it out? Debating on upgrading to 0.30.0 but might hold off if you're still seeing this issue.