fix: preserve keyframe selector casing in error messages - #571
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe rule continues case-insensitive duplicate detection and now reports duplicate selectors with their original casing. Tests update expected diagnostic data for mixed-case selectors. ChangesKeyframe selector diagnostics
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| // @ts-ignore - children is a valid property for prelude | ||
| node.prelude.children.forEach(selector => { | ||
| const value = []; | ||
| const rawValue = []; |
There was a problem hiding this comment.
I do not think we need the variable rawValue.
We can just push the the values as we do currently and use the lowercase variant when computing key in the map callback (line 78).
There was a problem hiding this comment.
Thank you for the comment.
I hadn’t considered that keeping a separate rawValue array would mean maintaining the same data in two places.
I’ve updated the code as follows :)
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
no-duplicate-keyframe-selectorserror messages.TOis reported asTOinstead ofto.What changes did you make? (Give an overview)
Related Issues
fixes #562
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit
%.