From df62c26ad1679f5bc10cda3e2eedc839682e8a42 Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Wed, 14 Mar 2018 14:13:14 -0700 Subject: [PATCH 1/2] Changed HSB to HSL color model --- xml/System.Drawing/Color.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Drawing/Color.xml b/xml/System.Drawing/Color.xml index 74fcbc3027ff6..823d1411d13e6 100644 --- a/xml/System.Drawing/Color.xml +++ b/xml/System.Drawing/Color.xml @@ -2163,7 +2163,7 @@ - Gets the hue-saturation-brightness (HSB) brightness value for this structure. + Gets the hue-saturation-lightness (HSL) brightness value for this structure. The brightness of this . The brightness ranges from 0.0 through 1.0, where 0.0 represents black and 1.0 represents white. - Gets the hue-saturation-brightness (HSB) hue value, in degrees, for this structure. - The hue, in degrees, of this . The hue is measured in degrees, ranging from 0.0 through 360.0, in HSB color space. + Gets the hue-saturation-lightness (HSL) hue value, in degrees, for this structure. + The hue, in degrees, of this . The hue is measured in degrees, ranging from 0.0 through 360.0, in HSL color space. - Gets the hue-saturation-brightness (HSB) saturation value for this structure. + Gets the hue-saturation-lightness (HSL) saturation value for this structure. The saturation of this . The saturation ranges from 0.0 through 1.0, where 0.0 is grayscale and 1.0 is the most saturated. Date: Wed, 14 Mar 2018 14:41:44 -0700 Subject: [PATCH 2/2] Addressed review comments --- xml/System.Drawing/Color.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xml/System.Drawing/Color.xml b/xml/System.Drawing/Color.xml index 823d1411d13e6..8ab9038aaae85 100644 --- a/xml/System.Drawing/Color.xml +++ b/xml/System.Drawing/Color.xml @@ -1967,13 +1967,13 @@ - Creates an instance of a structure, `redShade`, to be used for comparisons. -- Iterates through the enumeration elements to find all known colors that have the same brightness as `redShade`. The iterations are terminated when 15 matches are found or the value of the loop counter is greater than the last element. +- Iterates through the enumeration elements to find all known colors that have the same lightness as `redShade`. The iterations are terminated when 15 matches are found or the value of the loop counter is greater than the last element. - During each iteration, saves the element—if it matches the criteria—in an array. - Uses a brush to paint rectangles. - The first rectangle is painted the color represented by `redShade`. Each of the other rectangles is painted a that matches the brightness of the `redShade`. + The first rectangle is painted the color represented by `redShade`. Each of the other rectangles is painted a that matches the lightness of the `redShade`. [!code-cpp[System.Drawing.ClassicColorExamples#5](~/samples/snippets/cpp/VS_Snippets_Winforms/System.Drawing.ClassicColorExamples/CPP/form1.cpp#5)] [!code-csharp[System.Drawing.ClassicColorExamples#5](~/samples/snippets/csharp/VS_Snippets_Winforms/System.Drawing.ClassicColorExamples/CS/form1.cs#5)] @@ -2163,8 +2163,8 @@ - Gets the hue-saturation-lightness (HSL) brightness value for this structure. - The brightness of this . The brightness ranges from 0.0 through 1.0, where 0.0 represents black and 1.0 represents white. + Gets the hue-saturation-lightness (HSL) lightness value for this structure. + The lightness of this . The lightness ranges from 0.0 through 1.0, where 0.0 represents black and 1.0 represents white. structure, `redShade`, to be used for comparisons. -- Iterates through the enumeration elements to find all known colors that have the same brightness as `redShade`. The iterations are terminated when 15 matches are found or the value of the loop counter is greater than the last element. +- Iterates through the enumeration elements to find all known colors that have the same lightness as `redShade`. The iterations are terminated when 15 matches are found or the value of the loop counter is greater than the last element. - During each iteration, saves the element—if it matches the criteria—in an array. - Uses a brush to paint rectangles. - The first rectangle is painted the color represented by `redShade`. Each of the other rectangles is painted a that matches the brightness of the `redShade`. + The first rectangle is painted the color represented by `redShade`. Each of the other rectangles is painted a that matches the lightness of the `redShade`. [!code-cpp[System.Drawing.ClassicColorExamples#6](~/samples/snippets/cpp/VS_Snippets_Winforms/System.Drawing.ClassicColorExamples/CPP/form1.cpp#6)] [!code-csharp[System.Drawing.ClassicColorExamples#6](~/samples/snippets/csharp/VS_Snippets_Winforms/System.Drawing.ClassicColorExamples/CS/form1.cs#6)]