From 6e59ad0b73b32ada4a12a279248cf4c17a8cc9f0 Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Fri, 9 Mar 2018 17:06:31 -0500 Subject: [PATCH 1/3] Experiment: CodeOwners Trying an experiment to see how we might use use the CODEOWNERS file to get reviews routed to the right person. --- .github/CODEOWNERS | 27 +++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000000..663a7e2af2f74 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,27 @@ +# Lines starting with '#' are comments. +# Each line is a file pattern followed by one or more owners. + +# More details are here: https://help.github.com/articles/about-codeowners/ + +# The '*' pattern is global owners. +# Not adding in this PR, but I'd like to try adding a global owner set with the entire team. +# One interpretation of their docs is that global owners are added only if not removed +# by a more local rule. + +# Order is important. The last matching pattern has the most precedence. +# So if a pull request only touches javascript files, only these owners +# will be requested to review. + + +# The C# Guide: + +/docs/csharp/** BillWagner + +# C# samples: +/samples/csharp/** BillWagner + +# C# Snippets: +/samples/snippets/** BillWagner + +# Analyzers: +/docs/standard/analyzers/** BillWagner diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ae1eabb9dd1e2..ad634d5a20080 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -27,4 +27,4 @@ sufficient to describe that PR. ## Suggested Reviewers -If you know who should review this, use '@' to request a review. +If you know who should review this, tag them as a suggested reviewer in the list of reviewers. From 00210517e5e1c91131e1a6d8bb804f65a851da7b Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Fri, 9 Mar 2018 14:19:58 -0800 Subject: [PATCH 2/3] Added several sections --- .github/CODEOWNERS | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 663a7e2af2f74..28e6823798840 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -25,3 +25,14 @@ # Analyzers: /docs/standard/analyzers/** BillWagner + +# The Visual Basic Guide: +/docs/visual-basic/** rpetrusha + +# .NET Framework migration guide +/docs/framework/migration-guide/** rpetrusha + +# .NET base types +/docs/standard/base-types/formatting-types/** rpetrusha + + From b2f9c4fddca33129a79a21b0a1767be752d1cf35 Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Fri, 9 Mar 2018 16:38:42 -0800 Subject: [PATCH 3/3] Update CODEOWNERS --- .github/CODEOWNERS | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 28e6823798840..1de8dafedd974 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -29,10 +29,37 @@ # The Visual Basic Guide: /docs/visual-basic/** rpetrusha +# Visual Basic snippets: +/samples/snippets/visualbasic/** rpetrusha + +# C++ snippets +/samples/snippets/cpp/** rpetrusha + # .NET Framework migration guide /docs/framework/migration-guide/** rpetrusha # .NET base types /docs/standard/base-types/formatting-types/** rpetrusha +# .NET Framework unmanaged API +/docs/framework/unmanaged-api/** rpetrusha + +# What's New +/docs/core/whats-new/** rpetrusha +/docs/framework/whats-new/** rpetrusha +/docs/standard/whats-new/** rpetrusha + +# .NET Core +/docs/core/** mairaw + +# .NET Framework Security +/docs/framework/security/** mairaw + +# .NET I/O +/docs/standard/io/** mairaw + +# Docker +/docs/core/docker/** JRAlexander + +