From b0cadbcf2e1038111702ba95a317656b1cba4e1b Mon Sep 17 00:00:00 2001 From: DJ Majumdar Date: Sat, 21 Mar 2026 20:35:38 -0700 Subject: [PATCH] fix: use distinct critcmp group names for PR benchmark comparison critcmp compares exported JSON files by passing them as positional arguments. The previous commit incorrectly used a non-existent --import flag. Pass baseline.json and pr.json directly instead. --- .github/workflows/benchmarks.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index c2b8a3c..60a21f9 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -90,12 +90,9 @@ jobs: echo "::warning::No benchmark baseline found. Merge to main to generate one." exit 0 fi - # Import the cached baseline under the name "main" so critcmp - # can distinguish the two groups and produce a side-by-side comparison. - critcmp --import baseline.json --name main critcmp --export current > pr.json echo 'result<> $GITHUB_OUTPUT - critcmp main current >> $GITHUB_OUTPUT + critcmp baseline.json pr.json >> $GITHUB_OUTPUT echo 'EOF' >> $GITHUB_OUTPUT - name: Find existing comment