From dffaf995be5e2bc88d28e2607d744cf2efbe17eb Mon Sep 17 00:00:00 2001 From: James Gwatkin Date: Mon, 29 Apr 2024 17:06:55 +0100 Subject: [PATCH 1/2] Modified Log Levels Changed logging level when adding a document to the queue to prevent large amounts of logging when pushing large numbers of documents. In addition removed a System.out.println statement. --- .../java/com/coveo/pushapiclient/DocumentUploadQueue.java | 8 ++++++-- .../coveo/pushapiclient/StreamDocumentUploadQueue.java | 4 +++- .../java/com/coveo/pushapiclient/UpdateStreamService.java | 1 - 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java b/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java index 83168820..5b76495e 100644 --- a/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java +++ b/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java @@ -64,7 +64,9 @@ public void add(DocumentBuilder document) throws IOException, InterruptedExcepti this.flush(); } documentToAddList.add(document); - logger.info("Adding document to batch: " + document.getDocument().uri); + if (logger.isDebugEnabled()) { + logger.info("Adding document to batch: " + document.getDocument().uri); + } this.size += sizeOfDoc; } @@ -86,7 +88,9 @@ public void add(DeleteDocument document) throws IOException, InterruptedExceptio this.flush(); } documentToDeleteList.add(document); - logger.info("Adding document to batch: " + document.documentId); + if (logger.isDebugEnabled()) { + logger.debug("Adding document to batch: " + document.documentId); + } this.size += sizeOfDoc; } diff --git a/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java b/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java index 7a039f7a..0d0ced9d 100644 --- a/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java +++ b/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java @@ -56,7 +56,9 @@ public void add(PartialUpdateDocument document) throws IOException, InterruptedE this.flush(); } documentToPartiallyUpdateList.add(document); - logger.info("Adding document to batch: " + document.documentId); + if (logger.isDebugEnabled()) { + logger.info("Adding document to batch: " + document.documentId); + } this.size += sizeOfDoc; } diff --git a/src/main/java/com/coveo/pushapiclient/UpdateStreamService.java b/src/main/java/com/coveo/pushapiclient/UpdateStreamService.java index 4500d11f..948c3461 100644 --- a/src/main/java/com/coveo/pushapiclient/UpdateStreamService.java +++ b/src/main/java/com/coveo/pushapiclient/UpdateStreamService.java @@ -218,7 +218,6 @@ public HttpResponse close() private UploadStrategy getUploadStrategy() { return (streamUpdate) -> { String batchUpdateJson = new Gson().toJson(streamUpdate.marshal()); - System.out.println(batchUpdateJson); return this.platformClient.uploadContentToFileContainer(fileContainer, batchUpdateJson); }; } From 89d773339016c7674ea4b6a652b4c35324133f4f Mon Sep 17 00:00:00 2001 From: James Gwatkin Date: Mon, 29 Apr 2024 17:15:34 +0100 Subject: [PATCH 2/2] Changed the log level Updated as I forgot to change the log level inside the if condition. --- src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java | 2 +- .../java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java b/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java index 5b76495e..d3cc8480 100644 --- a/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java +++ b/src/main/java/com/coveo/pushapiclient/DocumentUploadQueue.java @@ -65,7 +65,7 @@ public void add(DocumentBuilder document) throws IOException, InterruptedExcepti } documentToAddList.add(document); if (logger.isDebugEnabled()) { - logger.info("Adding document to batch: " + document.getDocument().uri); + logger.debug("Adding document to batch: " + document.getDocument().uri); } this.size += sizeOfDoc; } diff --git a/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java b/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java index 0d0ced9d..c4e6ecd9 100644 --- a/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java +++ b/src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java @@ -57,7 +57,7 @@ public void add(PartialUpdateDocument document) throws IOException, InterruptedE } documentToPartiallyUpdateList.add(document); if (logger.isDebugEnabled()) { - logger.info("Adding document to batch: " + document.documentId); + logger.debug("Adding document to batch: " + document.documentId); } this.size += sizeOfDoc; }