feat: add create method in CatalogSource and PushSource (LENS-874) - #35
Merged
Conversation
hdhayneCoveo
requested review from
a team,
btaillon-coveo,
olamothe and
y-lakhdar
and removed request for
a team
May 30, 2023 21:03
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
y-lakhdar
requested changes
May 31, 2023
y-lakhdar
approved these changes
Jun 1, 2023
y-lakhdar
left a comment
y-lakhdar
left a comment
Contributor
There was a problem hiding this comment.
Good job, I just included additional info in some function documentation
Co-authored-by: Yassine <ylakhdar@coveo.com>
Co-authored-by: Yassine <ylakhdar@coveo.com>
Co-authored-by: Yassine <ylakhdar@coveo.com>
…ith deprecated note
Co-authored-by: Yassine <ylakhdar@coveo.com>
Co-authored-by: Yassine <ylakhdar@coveo.com>
y-lakhdar
changed the title
CatalogSource and PushSource (LENS-874)
y-lakhdar
pushed a commit
that referenced
this pull request
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in this PR , i created a new static method to create a new Catalog Source in Coveo org