Conversation
Update src/main/java/com/coveo/pushapiclient/ApiUrl.java Co-authored-by: Benjamin Taillon <54454747+btaillon@users.noreply.github.com> add new getter to source classes feat: create `PushSource` and `catalogSource` classes (#30) https://coveord.atlassian.net/browse/LENS-839 update StreamService add platformClient tests add PowerMockito dependencies remove unused import remove unecessary method downgrade build to Java 11 revert codeql deletion lint lint
Co-authored-by: Benjamin Taillon <54454747+btaillon@users.noreply.github.com>
Co-authored-by: jpmarceau <39384459+jpmarceau@users.noreply.github.com>
Co-authored-by: jpmarceau <39384459+jpmarceau@users.noreply.github.com>
y-lakhdar
requested review from
a team,
btaillon-coveo,
hdhayneCoveo,
louis-bompart and
olamothe
and removed request for
a team
May 30, 2023 17:52
louis-bompart
left a comment
louis-bompart
left a comment
Contributor
There was a problem hiding this comment.
lgtm, wonder about the choice of Collection, would be nice to justify it (given our lack of expertise in Java)
btaillon-coveo
approved these changes
May 31, 2023
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
y-lakhdar
enabled auto-merge (squash)
May 31, 2023 18:07
y-lakhdar
added a commit
that referenced
this pull request
Jun 20, 2023
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the
DocumentUploadQueueclass that will craft and upload document batches to a source.Proposed changes
The batching logic works as follow:
Whenever a document gets added to a
DocumentUploadQueueinstance, the doc gets accumulated into a buffer until one of the 2 conditions is met:flush()method.As soon as one condition is met, the accumulated documents in the queue are batched and uploaded to the source with the appropriate push strategy.
The queue maximum size limit is set to 5MB (even if the catalog payload limit is 256MB) : https://coveord.atlassian.net/browse/LENS-856 for explanation.
Testing
Created the
DocumentUploadQueueTestclass to test the addition of bulky documents (2MB documents) to simulate the upload of large data set.Adding several of these document should trigger automated batching and should be completely transparent to the user.