fix(LENS-1799): logging improvements - #131
Merged
Merged
Conversation
Changed logging level when adding a document to the queue to prevent large amounts of logging when pushing large numbers of documents. In addition removed a System.out.println statement.
jgwatkincoveo
requested review from
a team,
louis-bompart,
olamothe,
sallainCoveo,
samisayegh and
y-lakhdar
and removed request for
a team
April 29, 2024 16:13
Updated as I forgot to change the log level inside the if condition.
samisayegh
approved these changes
Apr 29, 2024
sallainCoveo
approved these changes
Apr 29, 2024
louis-bompart
approved these changes
Apr 29, 2024
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified logging level when adding documents to a queue so that when there are large numbers of documents to push, the logs are not filled with all the documents that are added.
Also removed a System.out.println statement.