From 5bf4055f6af56b5643dc4639bce527f0f4148a04 Mon Sep 17 00:00:00 2001 From: Max Yinger Date: Wed, 16 Sep 2026 12:37:21 -0600 Subject: [PATCH 1/2] fix(ui): position mosaic link button underline from the font metric Co-Authored-By: Claude Opus 5 (1M context) --- .changeset/button-link-underline-from-font.md | 2 ++ .../ui/src/mosaic/components/button/button.styles.ts | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/button-link-underline-from-font.md diff --git a/.changeset/button-link-underline-from-font.md b/.changeset/button-link-underline-from-font.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/button-link-underline-from-font.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/packages/ui/src/mosaic/components/button/button.styles.ts b/packages/ui/src/mosaic/components/button/button.styles.ts index 24e85561a71..64c0b12baad 100644 --- a/packages/ui/src/mosaic/components/button/button.styles.ts +++ b/packages/ui/src/mosaic/components/button/button.styles.ts @@ -391,7 +391,8 @@ export const variants = stylex.create({ paddingInlineStart: 0, textDecorationColor: { default: 'transparent', ':not([data-disabled]):hover': 'currentColor' }, textDecorationLine: 'underline', - textUnderlineOffset: '2px', + textDecorationSkipInk: 'auto', + textUnderlinePosition: 'from-font', height: 'auto', }, 'link-neutral': { @@ -408,7 +409,8 @@ export const variants = stylex.create({ paddingInlineStart: 0, textDecorationColor: { default: 'transparent', ':not([data-disabled]):hover': 'currentColor' }, textDecorationLine: 'underline', - textUnderlineOffset: '2px', + textDecorationSkipInk: 'auto', + textUnderlinePosition: 'from-font', height: 'auto', }, 'link-negative': { @@ -425,7 +427,8 @@ export const variants = stylex.create({ paddingInlineStart: 0, textDecorationColor: { default: 'transparent', ':not([data-disabled]):hover': 'currentColor' }, textDecorationLine: 'underline', - textUnderlineOffset: '2px', + textDecorationSkipInk: 'auto', + textUnderlinePosition: 'from-font', height: 'auto', }, }); From 446c028f3a5328325a470e41e2a7249e338e53c1 Mon Sep 17 00:00:00 2001 From: Max Yinger Date: Thu, 17 Sep 2026 12:09:56 -0600 Subject: [PATCH 2/2] chore(mosaic): add changeset for link button underline position Co-Authored-By: Claude Opus 5 (1M context) --- .changeset/button-link-underline-from-font.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.changeset/button-link-underline-from-font.md b/.changeset/button-link-underline-from-font.md index a845151cc84..72006395211 100644 --- a/.changeset/button-link-underline-from-font.md +++ b/.changeset/button-link-underline-from-font.md @@ -1,2 +1,5 @@ --- +'@clerk/mosaic': patch --- + +Update link button to use underline position from font over hardcoded offset