From f6ca7e2dd2b41f040cc268259b25d63a0c0aab1f Mon Sep 17 00:00:00 2001 From: Ray Matharu Date: Mon, 26 Aug 2019 11:51:05 -0700 Subject: [PATCH] Removing use of logger from appender --- .../samza/logging/log4j/SimpleDiagnosticsAppender.java | 10 ++-------- .../logging/log4j2/SimpleDiagnosticsAppender.java | 10 ++-------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java index 95135b2904..4aed996d0a 100644 --- a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java +++ b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java @@ -23,8 +23,6 @@ import org.apache.log4j.spi.LoggingEvent; import org.apache.samza.diagnostics.DiagnosticsExceptionEvent; import org.apache.samza.diagnostics.DiagnosticsManager; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** @@ -35,7 +33,6 @@ * stream of diagnostics-related events. */ public class SimpleDiagnosticsAppender extends AppenderSkeleton { - private static final Logger LOG = LoggerFactory.getLogger(SimpleDiagnosticsAppender.class); // simple object to synchronize root logger attachment private static final Object SYNCHRONIZATION_OBJECT = new Object(); @@ -57,7 +54,7 @@ public SimpleDiagnosticsAppender(DiagnosticsManager diagnosticsManager) { private void attachAppenderToRootLogger() { // ensure appender is attached only once per JVM (regardless of #containers) if (org.apache.log4j.Logger.getRootLogger().getAppender(SimpleDiagnosticsAppender.class.getName()) == null) { - LOG.info("Attaching diagnostics appender to root logger"); + System.out.println("Attaching diagnostics appender to root logger"); org.apache.log4j.Logger.getRootLogger().addAppender(this); } } @@ -73,13 +70,10 @@ protected void append(LoggingEvent loggingEvent) { loggingEvent.getProperties()); diagnosticsManager.addExceptionEvent(diagnosticsExceptionEvent); - LOG.debug("Received DiagnosticsExceptionEvent " + diagnosticsExceptionEvent); - } else { - LOG.debug("Received non-exception event with message " + loggingEvent.getMessage()); } } catch (Exception e) { // blanket catch of all exceptions so as to not impact any job - LOG.error("Exception in logging event parsing", e); + System.err.println("Exception in logging event parsing " + e); } } diff --git a/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java b/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java index 932b3f7392..fa6519939c 100644 --- a/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java +++ b/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java @@ -28,8 +28,6 @@ import org.apache.logging.log4j.core.config.LoggerConfig; import org.apache.samza.diagnostics.DiagnosticsExceptionEvent; import org.apache.samza.diagnostics.DiagnosticsManager; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * Provides an in-memory appender that parses LogEvents to filter events relevant to diagnostics. @@ -39,7 +37,6 @@ * stream of diagnostics-related events. */ public class SimpleDiagnosticsAppender extends AbstractAppender { - private static final Logger LOG = LoggerFactory.getLogger(SimpleDiagnosticsAppender.class); // simple object to synchronize root logger attachment private static final Object SYNCHRONIZATION_OBJECT = new Object(); @@ -62,7 +59,7 @@ private void attachAppenderToLoggers(Appender appender) { // ensure appender is attached only once per JVM (regardless of #containers) if (config.getRootLogger().getAppenders().get(SimpleDiagnosticsAppender.class.getName()) == null) { - LOG.info("Attaching diagnostics appender to root logger"); + System.out.println("Attaching diagnostics appender to root logger"); appender.start(); config.addAppender(appender); for (final LoggerConfig loggerConfig : config.getLoggers().values()) { @@ -81,13 +78,10 @@ public void append(LogEvent logEvent) { logEvent.getContextData().toMap()); diagnosticsManager.addExceptionEvent(diagnosticsExceptionEvent); - LOG.debug("Received DiagnosticsExceptionEvent " + diagnosticsExceptionEvent); - } else { - LOG.debug("Received non-exception event with message " + logEvent.getMessage()); } } catch (Exception e) { // blanket catch of all exceptions so as to not impact any job - LOG.error("Exception in logevent parsing", e); + System.err.println("Exception in logevent parsing " + e); } } }