Repository navigation
build: secondary entry points - #4363
devversion wants to merge 6 commits into
Conversation
googlebot
added
the
cla: yes
|
|
||
| /** Manages active item in option list based on key events. */ | ||
| _keyManager: ActiveDescendantKeyManager; | ||
| _keyManager: _ActiveDescendantKeyManager; |
There was a problem hiding this comment.
It would be better not to change the names of any symbols in this PR since it may make it harder to land in Google. We can potentially do renaming in a follow-up, though I'm not sure yet it's necessary,
There was a problem hiding this comment.
We can totally remove them, but the idea (from angular core) was to not "expose" those things to the public.
Though we don't have much stuff in our private_exports file, so we would be fine by just exposing those?
| /** | ||
| * When compiling with @angular/tsc-wrapped, shorthand imports will be converted into more | ||
| * explicit paths. This function rewrites all expanded imports to their original import. | ||
| * This is important, because when composing releases, the directories won't be present anymore. |
There was a problem hiding this comment.
Is there an issue on angular/angular tracking this?
There was a problem hiding this comment.
It's not an issue on angular/angular. It's a feature on tsickle. I was talking to @alexeagle about adding a flag or something so we can be more flexible about it.
| const releasePath = join(DIST_ROOT, 'releases', packageName); | ||
|
|
||
| const umdOutput = join(releasePath, 'bundles'); | ||
| const fesmOutput = join(releasePath, '@angular'); |
There was a problem hiding this comment.
Each of the secondary entry-points should be output into @angular/material (with material.js still directly under @angular)
(this part is for closure compiler)
There was a problem hiding this comment.
Yeah I think it should be like that?
| @angular/material
| -- @angular/
| -- -- material.js
| -- -- material/
| -- -- -- core.js
| } | ||
|
|
||
| export async function buildPackage(entryFile: string, packagePath: string, packageName: string) { | ||
| let packageTasks = [buildPackageBundles(entryFile, packageName)]; |
There was a problem hiding this comment.
Looks like buildPackageBundles doesn't return anything, so you're ending up with an array of undefined
There was a problem hiding this comment.
It does return a promise. Every function that uses async/await automatically returns them
|
We are holding off with that for now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
WIP