From 019680d90190b1ca7eaadb3e4b1daf10e2d6134c Mon Sep 17 00:00:00 2001 From: Zohaib Khan Date: Fri, 11 Sep 2026 15:55:48 +0100 Subject: [PATCH] fix(PLT-4267): upgrade Node.js to 22 for content-type compatibility The deploy-preview job installs @typeform/jarvis at CI time, which now resolves content-type@3.0.0 transitively. That package declares engines.node >=22, so yarn aborts the install under Node 20. Bumps both jobs in pull-request.yml to Node 22 and updates the yarn cache keys to match, so a node-20 cache is not restored into a node-22 job. Also drops a stray trailing blank line that was already failing prettier-check on main. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/pull-request.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index d917b99..0b41a0c 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -15,7 +15,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 20 + node-version: 22 - name: Get yarn cache uses: actions/cache@v4 @@ -24,7 +24,7 @@ jobs: path: | **/node_modules ~/.cache - key: ${{ runner.os }}-repo-${{ github.event.pull_request.head.repo.full_name }}-node-20-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('.github/workflows/**.yml') }} + key: ${{ runner.os }}-repo-${{ github.event.pull_request.head.repo.full_name }}-node-22-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('.github/workflows/**.yml') }} - name: Install Node.js dependencies # run when cache not found or PR is external (build fails for external PRs if dependencies are not installed) @@ -55,7 +55,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 20 + node-version: 22 - name: Get yarn cache uses: actions/cache@v4 @@ -64,7 +64,7 @@ jobs: path: | **/node_modules ~/.cache - key: ${{ runner.os }}-repo-${{ github.event.pull_request.head.repo.full_name }}-node-20-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('.github/workflows/**.yml') }} + key: ${{ runner.os }}-repo-${{ github.event.pull_request.head.repo.full_name }}-node-22-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('.github/workflows/**.yml') }} - name: Install Node.js dependencies # run when cache not found or PR is external (build fails for external PRs if dependencies are not installed) @@ -102,4 +102,3 @@ jobs: GH_TOKEN: ${{ secrets.GH_TOKEN }} JARVIS_NOTIFY_PREVIEW_TEMPLATE: ${{ secrets.JARVIS_NOTIFY_PREVIEW_TEMPLATE }} PUBLIC_CDN_URL: 'https://btn.typeform.com' -