Skip to content

feat(ci): verify agent trust and preserve generated API contracts - #384

Open
dodeja wants to merge 21 commits into
mainfrom
cursor/land-agent-trust-main-c4b3
Open

dodeja wants to merge 21 commits into
mainfrom
cursor/land-agent-trust-main-c4b3

Conversation

@dodeja

@dodeja dodeja commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

The verifier checks registered MCP capabilities, public SDK exports, workspace toolchain ownership, and generated OpenAPI contracts. It detects missing or swapped tool implementation paths through imported handler calls and checks every page in MCP navigation, including guides outside the mcp/ prefix.

The OpenAPI contract preserves container resource discriminants, route cargo/shipment links, nullable location links, and route-location attribute IDs. A direct Containers API reference page now publishes GET /containers/{id}/route. PR #383 builds advisory policy evaluation on this verifier and must land afterward.

Local verification passed all seven agent-verify steps, 35 guard regressions, compiler-backed consumer contracts, workspace checks/builds/tests, generated-type comparison, and a 13-tool offline MCP handshake. One existing SDK live-token test is skipped.

The authenticated live preview gate currently fails because the production backend rejects the shared CI credential with HTTP 401. The MCP transport handshake passes. No sparse fixture mode, credential substitution, or gate bypass is used. Independent final review remains separate from local validation.

@mintlify

mintlify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
terminal49 🟢 Ready View Preview Oct 14, 2026, 4:56 AM

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Oct 14, 2026 6:58am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T07:14:06.258077Z 4241fb6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c24582a6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-agent-trust.mjs Outdated
Comment thread sdks/typescript-sdk/src/generated/terminal49.ts Outdated
Comment thread docs/openapi.json
Comment thread bin/check-agent-trust.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03019365fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdks/typescript-sdk/src/generated/terminal49.ts Outdated
Comment thread docs/openapi.json
Comment thread bin/check-agent-trust.mjs Outdated
@dodeja dodeja changed the title feat: land agent trust stack on main feat(ci): add and verify the agent trust foundation Oct 6, 2026
@dodeja dodeja changed the title feat(ci): add and verify the agent trust foundation feat(ci): verify agent trust and preserve generated API contracts Oct 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8594722586

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/agent-verify.mjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bcea9bab7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-agent-trust.mjs
Comment thread bin/check-agent-trust.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f5312ab72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-agent-trust.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2245417b57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/openapi.json
Comment thread docs/openapi.json
Comment thread bin/check-agent-trust.mjs Outdated
dodeja and others added 2 commits October 13, 2026 21:40
* feat: add stable agent verification gate

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* docs: add agent paved path and P-Stack wiring

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* fix: normalize exact Vite+ dependency pins

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* fix: restore OpenAPI type generation

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* chore: Auto-generate Postman collection from openapi.json [skip ci]

* fix: describe the container route contract

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* chore: Auto-generate Postman collection from openapi.json [skip ci]

* fix: type the container route schema

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* fix: tighten agent trust guidance and CI

Co-authored-by: Akshay Dodeja <dodeja@gmail.com>

* chore: Auto-generate Postman collection from openapi.json [skip ci]

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dodeja
dodeja force-pushed the cursor/land-agent-trust-main-c4b3 branch from 2245417 to 93de765 Compare October 14, 2026 04:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60fd25f6be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/openapi.json
Comment thread bin/check-agent-trust.mjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b28577641

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-openapi-types.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ce9d7d303

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-agent-trust.mjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6227713b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/check-agent-trust.mjs Outdated
}
const temporary = mkdtempSync(join(tmpdir(), 'sdk-export-emission-'));
try {
const options = { ...parsed.options, outDir: temporary };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve self-import resolution during emission verification

On a clean checkout where the ignored SDK dist/ directory does not exist, replacing the configured outDir with this temporary path breaks TypeScript's package self-reference mapping for source files that import @terminal49/sdk. I reproduced this with Node 24.15: the agent-trust step reports TS2307 for the SDK example/smoke files and exits before the workspace build can create dist, while the same gate passes once dist has been built. Capture compiler writes without changing the configured output directory (or otherwise preserve self-reference resolution) so the required full verification gate works in fresh CI checkouts.

AGENTS.md reference: AGENTS.md:L81-L82

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4241fb6b4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/agent-verify.mjs
]),
{
name: 'OpenAPI SDK type generation',
command: ['node', 'bin/check-openapi-types.mjs'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Verify generated MCP filter schemas in the completion gate

When an OpenAPI filter description or validation rule changes and the canonical SDK generator is run, this step verifies only the SDK artifacts; no agent-verify step regenerates and compares packages/mcp/src/generated/list-filter-schemas.ts. The workspace build and tests consume that stale file, so the required handoff gate can pass while the MCP tool schemas still expose outdated metadata or validation. Run the MCP filter generator in isolation and compare its output as part of this gate.

AGENTS.md reference: AGENTS.md:L51-L54

Useful? React with 👍 / 👎.

Comment thread bin/check-agent-trust.mjs
Comment on lines +142 to +143
if (options.incremental || options.composite)
options.tsBuildInfoFile = join(temporary, 'build.tsbuildinfo');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow the temporary TypeScript build-info output

When the SDK enables incremental or composite, this assigns tsBuildInfoFile under the temporary directory, but program.emit passes that .tsbuildinfo file through the same write callback; the callback then rejects it for being outside the configured dist directory. Consequently, agent-verify fails for either otherwise-valid compiler option despite this branch attempting to support them. Handle the build-info output separately from package artifacts.

AGENTS.md reference: AGENTS.md:L82-L82

Useful? React with 👍 / 👎.

This branch was successfully deployed

2 active (1 outdated) deployments
Preview — 4241fb6b Deployed Oct 14, 2026 by vercel[bot]
staging - docs — 9b285776 Deployed Oct 14, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant