Repository navigation
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c24582a6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03019365fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8594722586
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bcea9bab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f5312ab72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2245417b57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* feat: add stable agent verification gate Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * docs: add agent paved path and P-Stack wiring Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * fix: normalize exact Vite+ dependency pins Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * fix: restore OpenAPI type generation Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * chore: Auto-generate Postman collection from openapi.json [skip ci] * fix: describe the container route contract Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * chore: Auto-generate Postman collection from openapi.json [skip ci] * fix: type the container route schema Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * fix: tighten agent trust guidance and CI Co-authored-by: Akshay Dodeja <dodeja@gmail.com> * chore: Auto-generate Postman collection from openapi.json [skip ci] --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2245417 to
93de765
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60fd25f6be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b28577641
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ce9d7d303
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6227713b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| const temporary = mkdtempSync(join(tmpdir(), 'sdk-export-emission-')); | ||
| try { | ||
| const options = { ...parsed.options, outDir: temporary }; |
There was a problem hiding this comment.
Preserve self-import resolution during emission verification
On a clean checkout where the ignored SDK dist/ directory does not exist, replacing the configured outDir with this temporary path breaks TypeScript's package self-reference mapping for source files that import @terminal49/sdk. I reproduced this with Node 24.15: the agent-trust step reports TS2307 for the SDK example/smoke files and exits before the workspace build can create dist, while the same gate passes once dist has been built. Capture compiler writes without changing the configured output directory (or otherwise preserve self-reference resolution) so the required full verification gate works in fresh CI checkouts.
AGENTS.md reference: AGENTS.md:L81-L82
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4241fb6b4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ]), | ||
| { | ||
| name: 'OpenAPI SDK type generation', | ||
| command: ['node', 'bin/check-openapi-types.mjs'], |
There was a problem hiding this comment.
Verify generated MCP filter schemas in the completion gate
When an OpenAPI filter description or validation rule changes and the canonical SDK generator is run, this step verifies only the SDK artifacts; no agent-verify step regenerates and compares packages/mcp/src/generated/list-filter-schemas.ts. The workspace build and tests consume that stale file, so the required handoff gate can pass while the MCP tool schemas still expose outdated metadata or validation. Run the MCP filter generator in isolation and compare its output as part of this gate.
AGENTS.md reference: AGENTS.md:L51-L54
Useful? React with 👍 / 👎.
| if (options.incremental || options.composite) | ||
| options.tsBuildInfoFile = join(temporary, 'build.tsbuildinfo'); |
There was a problem hiding this comment.
Allow the temporary TypeScript build-info output
When the SDK enables incremental or composite, this assigns tsBuildInfoFile under the temporary directory, but program.emit passes that .tsbuildinfo file through the same write callback; the callback then rejects it for being outside the configured dist directory. Consequently, agent-verify fails for either otherwise-valid compiler option despite this branch attempting to support them. Handle the build-info output separately from package artifacts.
AGENTS.md reference: AGENTS.md:L82-L82
Useful? React with 👍 / 👎.
The verifier checks registered MCP capabilities, public SDK exports, workspace toolchain ownership, and generated OpenAPI contracts. It detects missing or swapped tool implementation paths through imported handler calls and checks every page in MCP navigation, including guides outside the mcp/ prefix.
The OpenAPI contract preserves container resource discriminants, route cargo/shipment links, nullable location links, and route-location attribute IDs. A direct Containers API reference page now publishes GET /containers/{id}/route. PR #383 builds advisory policy evaluation on this verifier and must land afterward.
Local verification passed all seven agent-verify steps, 35 guard regressions, compiler-backed consumer contracts, workspace checks/builds/tests, generated-type comparison, and a 13-tool offline MCP handshake. One existing SDK live-token test is skipped.
The authenticated live preview gate currently fails because the production backend rejects the shared CI credential with HTTP 401. The MCP transport handshake passes. No sparse fixture mode, credential substitution, or gate bypass is used. Independent final review remains separate from local validation.