From 582e76941c1c5524365e75f293fe1a0a64cb0fc8 Mon Sep 17 00:00:00 2001 From: zz_y Date: Thu, 9 Jul 2026 09:29:48 -0600 Subject: [PATCH] fix(test): cover QueryExpr::TimeShift in the netflow corpus visitor `main` does not compile: `cargo test -p asap-frontend-sql --test netflow` fails with E0004, non-exhaustive patterns. PR #106 added `QueryExpr::TimeShift` (the `offset` / `@` lowering for #40). PR #107 added the netflow corpus, whose `visit()` matches `QueryExpr` exhaustively, and was branched before #106 landed. Each PR was green on its own base; neither was rebased, so the breakage only appeared once both were on `main`. `TimeShift` is a single-child pass-through, so it joins the existing recurse-into-`child` arm. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/frontend-sql/tests/netflow/netflow.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/frontend-sql/tests/netflow/netflow.rs b/crates/frontend-sql/tests/netflow/netflow.rs index a0a9cd71..05207e26 100644 --- a/crates/frontend-sql/tests/netflow/netflow.rs +++ b/crates/frontend-sql/tests/netflow/netflow.rs @@ -267,6 +267,7 @@ fn visit(qe: &QueryExpr, f: &mut impl FnMut(&QueryExpr)) { | QueryExpr::WindowFunc { child, .. } | QueryExpr::Relabel { child, .. } | QueryExpr::Sample { child, .. } + | QueryExpr::TimeShift { child, .. } | QueryExpr::InfoJoin { child, .. } => visit(child, f), QueryExpr::BinaryOp { lhs, rhs, .. } | QueryExpr::Join {