Repository navigation
chore: Bump TypeScript to 5.8 - #4141
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
+ Coverage 98.60% 98.65% +0.05%
==========================================
Files 429 429
Lines 12513 12522 +9
Branches 1977 1979 +2
==========================================
+ Hits 12338 12354 +16
+ Misses 175 168 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FrederikBolding
marked this pull request as ready for review
October 8, 2026 10:10
FrederikBolding
commented
Oct 8, 2026
| <Input | ||
| name={component.name} | ||
| type={component.inputType} | ||
| type={component.inputType ?? InputType.Text} |
Member
Author
There was a problem hiding this comment.
This is also the default in the clients, so we may as well now that not having a default is a type error.
Mrtenz
reviewed
Oct 8, 2026
| ); | ||
| } | ||
|
|
||
| async bytes(): Promise<Uint8Array> { |
Member
Author
There was a problem hiding this comment.
Yes. It was added to Response in TypeScript and so required to not have a type error for implements Response.
Member
Author
There was a problem hiding this comment.
(and a good reminder for something we should have added 😅 )
Mrtenz
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump TypeScript to
~5.8.3and useNodeNext. This should unblock using ESM packages fromcore.Also fixes a couple of type issues after the TypeScript bump and adds a feature to the
fetchResponsethat we were missing.