Skip to content

feat: add desktop release and theme coverage notifications - #596

Merged
ReenigneArcher merged 3 commits into
masterfrom
feat/system-notifications
Oct 4, 2026
Merged

ReenigneArcher merged 3 commits into
masterfrom
feat/system-notifications

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Adds system notifications.

  • version updates
  • notification when theme coverage increases

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Show the installed version in the sidebar and tray About submenu, provide application and documentation links through a shared callback, and allow source version 0.0.0 to check for releases at startup.
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.42484% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.70%. Comparing base (d5a49d8) to head (ed78ff1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/common/notifications.py 95.16% 4 Missing and 2 partials ⚠️
src/common/definitions.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   88.17%   88.70%   +0.52%     
==========================================
  Files          34       36       +2     
  Lines        3815     3949     +134     
  Branches      562      586      +24     
==========================================
+ Hits         3364     3503     +139     
+ Misses        303      298       -5     
  Partials      148      148              
Flag Coverage Δ
Linux-aarch64 88.47% <95.42%> (+0.53%) ⬆️
Linux-x86_64 88.47% <95.42%> (+0.53%) ⬆️
Windows-AMD64 88.60% <95.42%> (+0.54%) ⬆️
Windows-ARM64 88.60% <95.42%> (+0.54%) ⬆️
macOS-arm64 88.47% <95.42%> (+0.53%) ⬆️
macOS-x86_64 88.47% <95.42%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/config.py 72.72% <ø> (ø)
src/common/http.py 96.90% <100.00%> (ø)
src/common/tray_icon.py 81.73% <100.00%> (-1.00%) ⬇️
src/common/version.py 100.00% <100.00%> (ø)
src/common/webapp.py 94.41% <100.00%> (+0.76%) ⬆️
src/themerr/cache.py 90.90% <100.00%> (+0.90%) ⬆️
src/themerr/scheduled_tasks.py 95.38% <100.00%> (+0.22%) ⬆️
src/themerr_plex.py 66.15% <100.00%> (+2.58%) ⬆️
src/common/definitions.py 83.33% <50.00%> (+11.59%) ⬆️
src/common/notifications.py 95.16% <95.16%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a49d8...ed78ff1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread docs/source/about/installation.rst Outdated
Extract per-release validation and filtering to reduce cognitive complexity. Remove the macOS configuration migration note requested in the PR review.
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 6fb6753 into master Oct 4, 2026
27 checks passed
@ReenigneArcher
ReenigneArcher deleted the feat/system-notifications branch October 4, 2026 04:29
@ReenigneArcher ReenigneArcher added this to the standalone milestone Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant