diff --git a/docs/dev/clang-tidy-fixes-2026-04.md b/docs/dev/clang-tidy-fixes-2026-04.md index 78d1cb80c..d6dfaa5aa 100644 --- a/docs/dev/clang-tidy-fixes-2026-04.md +++ b/docs/dev/clang-tidy-fixes-2026-04.md @@ -118,7 +118,8 @@ - [ ] [modernize-use-designated-initializers](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-designated-initializers.html) (69) - [x] [modernize-use-equals-default](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html) (7) - [PR #784](https://github.com/Framework-R-D/phlex/pull/784) -- [ ] [modernize-use-integer-sign-comparison](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-integer-sign-comparison.html) (7) +- [x] [modernize-use-integer-sign-comparison](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-integer-sign-comparison.html) (7) + - [PR #791](https://github.com/Framework-R-D/phlex/pull/791) - [x] [modernize-use-scoped-lock](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-scoped-lock.html) (6) - [PR #789](https://github.com/Framework-R-D/phlex/pull/789) - [x] [modernize-use-nullptr](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-nullptr.html) (194) diff --git a/plugins/python/src/modulewrap.cpp b/plugins/python/src/modulewrap.cpp index 2f1d4b946..4b6973576 100644 --- a/plugins/python/src/modulewrap.cpp +++ b/plugins/python/src/modulewrap.cpp @@ -557,6 +557,9 @@ namespace { } unsigned long ul = PyLong_AsUnsignedLong(pyobject); + // In this case, using 'std::cmp_equal(ul, -1)' returns the wrong result, so + // we suppress the clang-tidy warning re. 'ul == static_cast(-1)'. + // NOLINTNEXTLINE(modernize-use-integer-sign-comparison) if (ul == static_cast(-1) && PyErr_Occurred() && PyLong_Check(pyobject)) { PyErr_Clear(); long i = PyLong_AS_LONG(pyobject);