From ab184be8174ee409d6368509ad732eeff572abbf Mon Sep 17 00:00:00 2001 From: Kyle Knoepfel Date: Wed, 22 Jul 2026 10:00:36 -0500 Subject: [PATCH 1/2] Resolve readability-redundant-access-specifiers clang-tidy warning --- form/persistence/persistence_reader.hpp | 1 - form/persistence/persistence_writer.hpp | 1 - test/replicated.cpp | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/form/persistence/persistence_reader.hpp b/form/persistence/persistence_reader.hpp index 452aa89b8..a7adddb4e 100644 --- a/form/persistence/persistence_reader.hpp +++ b/form/persistence/persistence_reader.hpp @@ -47,7 +47,6 @@ namespace form::detail::experimental { std::string const& label, std::string const& id); - private: std::unique_ptr m_store_reader; form::experimental::config::ItemConfig m_config_items; form::experimental::config::tech_setting_config m_tech_settings; diff --git a/form/persistence/persistence_writer.hpp b/form/persistence/persistence_writer.hpp index b5f3043cd..ac198a7ff 100644 --- a/form/persistence/persistence_writer.hpp +++ b/form/persistence/persistence_writer.hpp @@ -40,7 +40,6 @@ namespace form::detail::experimental { private: std::unique_ptr getPlacement(std::string const& creator, std::string const& label); - private: std::unique_ptr m_store_writer; form::experimental::config::ItemConfig m_config_items; form::experimental::config::tech_setting_config m_tech_settings; diff --git a/test/replicated.cpp b/test/replicated.cpp index 3945f9b0c..f889dbf99 100644 --- a/test/replicated.cpp +++ b/test/replicated.cpp @@ -52,7 +52,7 @@ namespace { typename base_t::output_ports_type{broadcast_}); } - public: + private: tbb::flow::buffer_node buffer_; tbb::flow::broadcast_node broadcast_; std::vector modules_; From 9994d7010667a07dfc0c48ee6ddc87dad5ec4154 Mon Sep 17 00:00:00 2001 From: Kyle Knoepfel Date: Wed, 22 Jul 2026 10:00:41 -0500 Subject: [PATCH 2/2] docs: record PR #757 for readability-redundant-access-specifiers clang-tidy fixes --- docs/dev/clang-tidy-fixes-2026-04.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/dev/clang-tidy-fixes-2026-04.md b/docs/dev/clang-tidy-fixes-2026-04.md index 39e2a3051..53b26d8c1 100644 --- a/docs/dev/clang-tidy-fixes-2026-04.md +++ b/docs/dev/clang-tidy-fixes-2026-04.md @@ -158,7 +158,8 @@ - [ ] [readability-isolate-declaration](https://clang.llvm.org/extra/clang-tidy/checks/readability/isolate-declaration.html) (7) - [ ] [readability-math-missing-parentheses](https://clang.llvm.org/extra/clang-tidy/checks/readability/math-missing-parentheses.html) (6) - [ ] [readability-qualified-auto](https://clang.llvm.org/extra/clang-tidy/checks/readability/qualified-auto.html) (20) -- [ ] [readability-redundant-access-specifiers](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-access-specifiers.html) (3) +- [x] [readability-redundant-access-specifiers](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-access-specifiers.html) (3) + - [PR #757](https://github.com/Framework-R-D/phlex/pull/757) - [x] [readability-redundant-control-flow](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-control-flow.html) (19) - [PR #743](https://github.com/Framework-R-D/phlex/pull/743) - [ ] [readability-redundant-member-init](https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html) (24)