From 39bbd2f039d1c0583ad24e8a546ca52819dcf026 Mon Sep 17 00:00:00 2001
From: Ruben van der Linde <release-bot@conduction.nl>
Date: Wed, 12 Aug 2026 23:20:45 +0200
Subject: [PATCH] chore(quality): point PHPMD at the central ruleset

phpmd.xml becomes a 9-line stub referencing
vendor/conduction/hydra-gates/quality-config/phpmd.xml, and the local
phpmd-unusedparams.xml is deleted in favour of the central copy, which the
unused-parameters leg of the composer phpmd script now points at. Both legs,
their flags and the worst-exit-code behaviour are unchanged.
---
 composer.json          |   2 +-
 phpmd-unusedparams.xml |  40 --------------
 phpmd.xml              | 122 ++---------------------------------------
 3 files changed, 5 insertions(+), 159 deletions(-)
 delete mode 100644 phpmd-unusedparams.xml

diff --git a/composer.json b/composer.json
index c0b38497..289381fa 100644
--- a/composer.json
+++ b/composer.json
@@ -27,7 +27,7 @@
         "phpcs": "./vendor/bin/phpcs --standard=phpcs.xml",
         "phpcs:fix": "./vendor/bin/phpcbf --standard=phpcs.xml",
         "phpcs:output": "./vendor/bin/phpcs --standard=phpcs.xml --report=json lib/ 2>/dev/null | tail -1 > phpcs-output.json",
-        "phpmd": "E=0; ./vendor/bin/phpmd lib text phpmd.xml --baseline-file phpmd.baseline.xml || E=$?; ./vendor/bin/phpmd lib text phpmd-unusedparams.xml --baseline-file phpmd.baseline.xml || E=$?; exit $E",
+        "phpmd": "E=0; ./vendor/bin/phpmd lib text phpmd.xml --baseline-file phpmd.baseline.xml || E=$?; ./vendor/bin/phpmd lib text vendor/conduction/hydra-gates/quality-config/phpmd-unusedparams.xml --baseline-file phpmd.baseline.xml || E=$?; exit $E",
         "phpmetrics": "./vendor/bin/phpmetrics --report-html=phpmetrics lib/",
         "phpmetrics:violations": "./vendor/bin/phpmetrics --violations-xml=phpmetrics/violations.xml lib/",
         "psalm": "if [ -f vendor/bin/psalm ]; then ./vendor/bin/psalm --threads=1 --no-cache; else echo 'Psalm not installed, skipping...'; fi",
diff --git a/phpmd-unusedparams.xml b/phpmd-unusedparams.xml
deleted file mode 100644
index a109ae4e..00000000
--- a/phpmd-unusedparams.xml
+++ /dev/null
@@ -1,40 +0,0 @@
-<?xml version="1.0"?>
-<ruleset name="Unused formal parameters"
-    xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_xml_schema.xsd">
-
-    <description>
-        Second PHPMD leg: UnusedFormalParameter only.
-
-        This rule lives in its own ruleset because PHPMD honours &lt;exclude-pattern&gt;
-        ONLY as a direct child of &lt;ruleset&gt;; nested inside a &lt;rule&gt; it is parsed and
-        discarded (ConductionNL/.github#155). A direct child, however, is applied by
-        PDepend at file-collection time and drops the file from EVERY rule in the
-        ruleset. Isolating UnusedFormalParameter here means the lib/Migration
-        exclusion applies to this rule and this rule ALONE - every other rule still
-        analyses lib/Migration in the main leg.
-
-        Why lib/Migration is excluded from THIS rule: OCP\Migration\IMigrationStep
-        mandates changeSchema(IOutput $output, Closure $schemaClosure, array $options)
-        and preSchemaChange/postSchemaChange with the same three parameters. A step
-        that needs none of them still cannot drop them. The signature cannot change.
-
-        The pattern is */lib/Migration/* and deliberately NOT */Migration/* or
-        *Migration*. Those broader forms silently swallow ORDINARY CLASSES that merely
-        have "Migration" in their path - measured on openconnector, */Migration/* hides
-        a genuine finding in lib/Service/Migration/, and *Migration* additionally hides
-        every lib/Service/MigrationService.php, lib/Controller/MigrationController.php
-        and lib/Db/*Migration*.php. Those have no mandated signature and must stay
-        analysed. Only the app's own lib/Migration/ directory holds IMigrationStep
-        implementations, so only that directory is exempted.
-
-        Both legs must always run - see the "phpmd" script in composer.json, which
-        keeps the worst exit code rather than letting the first leg short-circuit
-        the second.
-    </description>
-
-    <exclude-pattern>*/lib/Migration/*</exclude-pattern>
-
-    <rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"/>
-</ruleset>
diff --git a/phpmd.xml b/phpmd.xml
index 5cea97ec..29d267a8 100644
--- a/phpmd.xml
+++ b/phpmd.xml
@@ -1,123 +1,9 @@
 <?xml version="1.0"?>
-<ruleset name="SoftwareCatalog Nextcloud Rules"
+<ruleset name="softwarecatalog"
     xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0
-                        http://pmd.sourceforge.net/ruleset_xml_schema.xsd">
+    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_xml_schema.xsd">
+    <description>softwarecatalog — Conduction PHPMD ruleset (single source: conduction/hydra-gates).</description>
 
-    <description>
-        This is a custom ruleset for SoftwareCatalog Nextcloud.
-    </description>
-
-    <!-- Clean Code Rules -->
-    <rule ref="rulesets/cleancode.xml/BooleanArgumentFlag"/>
-    <rule ref="rulesets/cleancode.xml/ElseExpression"/>
-    <rule ref="rulesets/cleancode.xml/StaticAccess"/>
-    <rule ref="rulesets/cleancode.xml/IfStatementAssignment"/>
-    <rule ref="rulesets/cleancode.xml/DuplicatedArrayKey"/>
-    <rule ref="rulesets/cleancode.xml/MissingImport"/>
-    <rule ref="rulesets/cleancode.xml/UndefinedVariable"/>
-    <rule ref="rulesets/cleancode.xml/ErrorControlOperator"/>
-
-    <!-- Code Size Rules -->
-    <rule ref="rulesets/codesize.xml/CyclomaticComplexity"/>
-    <rule ref="rulesets/codesize.xml/NPathComplexity"/>
-    <rule ref="rulesets/codesize.xml/ExcessiveMethodLength"/>
-    <rule ref="rulesets/codesize.xml/ExcessiveClassLength"/>
-    <rule ref="rulesets/codesize.xml/ExcessiveParameterList"/>
-    <rule ref="rulesets/codesize.xml/ExcessivePublicCount"/>
-    <rule ref="rulesets/codesize.xml/TooManyFields"/>
-    <rule ref="rulesets/codesize.xml/TooManyMethods"/>
-    <rule ref="rulesets/codesize.xml/TooManyPublicMethods"/>
-    <rule ref="rulesets/codesize.xml/ExcessiveClassComplexity"/>
-
-    <!-- Controversial Rules -->
-    <rule ref="rulesets/controversial.xml/Superglobals"/>
-    <rule ref="rulesets/controversial.xml/CamelCaseClassName"/>
-    <rule ref="rulesets/controversial.xml/CamelCasePropertyName"/>
-    <rule ref="rulesets/controversial.xml/CamelCaseMethodName"/>
-    <!-- CamelCaseParameterName removed - we allow leading underscores on parameters (convention for unused/config params) -->
-    <!-- <rule ref="rulesets/controversial.xml/CamelCaseParameterName"/> -->
-    <!-- CamelCaseVariableName removed - we allow leading underscores on variables (convention for unused loop vars) -->
-    <!-- <rule ref="rulesets/controversial.xml/CamelCaseVariableName"/> -->
-
-    <!-- Design Rules -->
-    <rule ref="rulesets/design.xml/ExitExpression"/>
-    <rule ref="rulesets/design.xml/EvalExpression"/>
-    <rule ref="rulesets/design.xml/GotoStatement"/>
-    <rule ref="rulesets/design.xml/NumberOfChildren"/>
-    <rule ref="rulesets/design.xml/DepthOfInheritance"/>
-    <rule ref="rulesets/design.xml/CouplingBetweenObjects"/>
-    <!-- DevelopmentCodeFragment MUST carry ignore-namespaces=true, or it is dead
-         code in this ruleset. See ConductionNL/openregister#2286.
-
-         PDepend resolves an unqualified call inside a namespaced file to the
-         CURRENT-NAMESPACE-qualified image, so `var_dump($x)` in
-         `namespace OCA\MyApp\Service;` reaches the rule as
-         `OCA\MyApp\Service\var_dump`, which never matches the
-         `unwanted-functions` list. All of our production PHP is namespaced, so
-         with the default (false) the rule catches nothing anywhere.
-
-         Measured on phpmd 2.15.0 / PHP 8.3.32: byte-identical probe class,
-         namespaced -> exit 0, non-namespaced -> exit 2. With
-         ignore-namespaces=true the rule strips the enclosing namespace before
-         matching, the namespaced probe is reported (exit 2), and a clean
-         namespaced file stays exit 0.
-
-         Note: hydra gate 2 (forbidden-patterns) independently greps lib/ for
-         var_dump / die / error_log / print_r / dd / dump and is the broader
-         control - it also catches calls outside methods, which this rule (a
-         MethodAware/FunctionAware rule) cannot see. This rule is the
-         `composer check:strict` half of the same guard; keep both. -->
-    <rule ref="rulesets/design.xml/DevelopmentCodeFragment">
-        <properties>
-            <property name="ignore-namespaces" value="true"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/design.xml/EmptyCatchBlock"/>
-    <rule ref="rulesets/design.xml/CountInLoopExpression"/>
-
-    <!-- Naming Rules -->
-    <rule ref="rulesets/naming.xml/LongClassName"/>
-    <rule ref="rulesets/naming.xml/ShortClassName"/>
-    <!-- ShortVariable configured with allowlist of idiomatic short names -->
-    <rule ref="rulesets/naming.xml/ShortVariable">
-        <properties>
-            <property name="minimum" value="3" />
-            <property name="exceptions" value="id,db,qb,op,ui,io,gc,tz,pk,fk,to,ch,a,b,l,v,c,t,r,f,n,k,e" />
-        </properties>
-    </rule>
-    <rule ref="rulesets/naming.xml/LongVariable"/>
-    <rule ref="rulesets/naming.xml/ShortMethodName"/>
-    <rule ref="rulesets/naming.xml/ConstructorWithNameAsEnclosingClass"/>
-    <rule ref="rulesets/naming.xml/ConstantNamingConventions"/>
-    <rule ref="rulesets/naming.xml/BooleanGetMethodName"/>
-
-    <!-- Unused Code Rules -->
-    <rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/>
-    <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
-    <rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/>
-    <!-- UnusedFormalParameter is NOT declared here. It lives alone in
-         phpmd-unusedparams.xml, which is run as a second leg by the "phpmd"
-         composer script.
-
-         Why: this rule used to carry a NESTED
-             <exclude-pattern>*Migration*</exclude-pattern>
-         meant to spare lib/Migration, whose changeSchema/preSchemaChange/
-         postSchemaChange signatures are mandated by OCP\Migration\IMigrationStep
-         and cannot drop their unused parameters. That pattern was INERT: PHPMD
-         2.15 reads exclude-patterns in RuleSetFactory::getIgnorePattern(), which
-         walks $xml->children() - i.e. only elements DIRECTLY under <ruleset>. A
-         nested one parses without error and does nothing, so lib/Migration was
-         always scanned by this rule (ConductionNL/.github#155).
-
-         Moving the pattern up to the top level of THIS file would make it
-         effective, but it is applied by PDepend's ExcludePathFilter at
-         file-collection time, so it drops lib/Migration from EVERY rule in the
-         ruleset - real complexity, StaticAccess and method-length findings in
-         migrations would silently vanish.
-
-         Isolating the rule in its own ruleset gives the exclusion a top-level
-         home that scopes it to this one rule, while the main leg above keeps
-         analysing lib/Migration with everything else. -->
+    <rule ref="vendor/conduction/hydra-gates/quality-config/phpmd.xml"/>
 </ruleset>