From 17f77b341398feba996d45c377a7377edca85a17 Mon Sep 17 00:00:00 2001
From: Ruben van der Linde <rubenvdlinde@gmail.com>
Date: Wed, 12 Aug 2026 21:08:15 +0200
Subject: [PATCH] fix(install): seed on a FRESH install, not only on upgrade

Nextcloud runs migrateSchemaOnly() on a first install: $previousVersion is
'', so Installer::installAppLastSteps() skips BOTH pre-migration and
post-migration, and <install> is the only unconditional hook. The upgrade
path runs pre/post-migration and NOT install, so an app needs both blocks
carrying the same baseline steps, each idempotent.

Until now this app declared no <install> block at all, so the SoftwareCatalog register
never arrived on a fresh instance.

Only baseline-CREATING steps are added; migrations, backfills, renames and
cross-app ingests stay upgrade-only so they never run against an empty
database. <install> is placed after </post-migration> per the info.xsd
sequence (pre-migration, post-migration, live-migration, install, uninstall),
verified against the schema.
---
 appinfo/info.xml | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/appinfo/info.xml b/appinfo/info.xml
index aba86f35..0ee207b9 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -115,6 +115,24 @@ Vrij en open source onder de EUPL-licentie.
 			-->
 			<step>OCA\SoftwareCatalog\Repair\RenameDutchCatalogColumns</step>
 		</post-migration>
+		<!--
+			FRESH INSTALL. Nextcloud does NOT run post-migration on a first install:
+			`Installer::installAppLastSteps()` guards both the pre-migration and
+			post-migration blocks with `if ($previousVersion !== '')`, and only
+			`repair-steps/install` runs unconditionally afterwards. Until this block
+			existed a brand-new SoftwareCatalog install ran NONE of the steps above,
+			so InitializeSettings never fired and the register was never imported —
+			despite that step's own docblock saying it initialises settings "on
+			install/upgrade".
+
+			Only InitializeSettings belongs here. MigrateContactsToNc,
+			BackfillContractApprovalState and RenameDutchCatalogColumns are all
+			migrations or backfills over data a fresh install does not yet have, so
+			they stay upgrade-only rather than running against an empty database.
+		-->
+		<install>
+			<step>OCA\SoftwareCatalog\Repair\InitializeSettings</step>
+		</install>
 	</repair-steps>
 
 	<settings>