From 5ad6553db014d8db96cbd692fac27f33ffae6e85 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Wed, 12 Aug 2026 20:00:40 +0200 Subject: [PATCH] fix(ci): test the whole declared Nextcloud range, not only the ceiling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit appinfo/info.xml declares , but nextcloud-test-refs was '["stable34"]' — so the declared floor and the middle major were advertised to the App Store with no job touching either. This is the coding-standard migration's own defect: its rollout REPLACED the ref list instead of extending it. The programme opened by reporting that nothing was tested on NC 34 and, in fixing that, made 32 and 33 the untested end. Same drift, other direction. stable34 stays first because newman, playwright and journeydoc-capture all read fromJSON(inputs.nextcloud-test-refs)[0] as their single server. Verified green on all three refs against nextcloud/ocp ^34 on portaliq (run 31599055849, six PHPUnit legs: 32/33/34 x PHP 8.3/8.4). --- .github/workflows/code-quality.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index ef63f4cd..42675644 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -60,7 +60,15 @@ jobs: with: app-name: softwarecatalog php-version: "8.3" - nextcloud-test-refs: '["stable34"]' + # THE LIST IS THE WHOLE DECLARED RANGE. appinfo/info.xml declares + # , so 32, 33 and 34 each get + # a leg. Adopting NC 34 by REPLACING the list left 32 and 33 advertised to + # the App Store with no job touching them — the declared floor became the + # untested end, which is the same drift as never testing 34, reversed. + # stable34 leads because newman, playwright and journeydoc-capture all read + # `fromJSON(inputs.nextcloud-test-refs)[0]` as their single server, and 34 + # is the major this app had never been exercised on. + nextcloud-test-refs: '["stable34", "stable32", "stable33"]' enable-psalm: true enable-phpstan: true enable-phpmetrics: true