From b51d62a84db05c6f0274542cc8ac1fda0ee4a464 Mon Sep 17 00:00:00 2001 From: Conduction Release Bot Date: Mon, 10 Aug 2026 22:37:40 +0200 Subject: [PATCH 1/2] fix(fe): extract four inline modals, and fix the mis-named slot that made four settings info panels render empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gate-13 (modal-isolation) reported three files with inline NcModal/NcDialog markup. Fixing them surfaced a second, unrelated defect that no gate and no test could see, because its failure mode is silence. THE SLOT BUG AlwaysVisibleSection declared ``. Four callers pass ` + + diff --git a/src/dialogs/ManageUserGroupsDialog.vue b/src/dialogs/ManageUserGroupsDialog.vue new file mode 100644 index 00000000..3ddca3ba --- /dev/null +++ b/src/dialogs/ManageUserGroupsDialog.vue @@ -0,0 +1,231 @@ + + + + + + + diff --git a/src/modals/AlwaysVisibleSectionInfoModal.vue b/src/modals/AlwaysVisibleSectionInfoModal.vue new file mode 100644 index 00000000..91a42d67 --- /dev/null +++ b/src/modals/AlwaysVisibleSectionInfoModal.vue @@ -0,0 +1,74 @@ + + + + + + + diff --git a/src/modals/CollapsibleSectionInfoModal.vue b/src/modals/CollapsibleSectionInfoModal.vue new file mode 100644 index 00000000..434b2073 --- /dev/null +++ b/src/modals/CollapsibleSectionInfoModal.vue @@ -0,0 +1,134 @@ + + + + + + + diff --git a/tests/vitest/sectionInfoSlot.spec.js b/tests/vitest/sectionInfoSlot.spec.js new file mode 100644 index 00000000..7969d529 --- /dev/null +++ b/tests/vitest/sectionInfoSlot.spec.js @@ -0,0 +1,147 @@ +// @vitest-environment jsdom + +/** + * SPDX-FileCopyrightText: 2026 Conduction / SoftwareCatalog Contributors + * SPDX-License-Identifier: EUPL-1.2 + * + * Regression tests for the settings-section INFO SLOT CONTRACT. + * + * Why this exists + * --------------- + * `AlwaysVisibleSection.vue` declared ``, but FOUR of its + * five callers pass `