Skip to content

Commit e77101e

Browse files
authored
fix: limit windows test concurrency (#2205)
Fixes #2137. This updates the test workflow so Windows jobs run the Node test runner with `--test-concurrency=1`. The issue points to intermittent Windows failures where the browser target closes during screenshot tests. Those tests start real browser sessions, and limiting test concurrency on Windows avoids overlapping screenshot/browser work there while keeping the existing parallel behavior on Linux and macOS. Verification: - `git diff --check` - Inspected the workflow command expansion: only `windows-latest` receives `--test-concurrency=1`; merge queue retries still pass `--retry` as before.
1 parent ed02047 commit e77101e

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/run-tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,10 @@ jobs:
6666
- name: Run tests
6767
shell: bash
6868
# Retry tests if they fail in the merge queue.
69-
run: npm run test:no-build -- ${{ github.event_name == 'merge_group' && '--retry' || '' }}
69+
run: >
70+
npm run test:no-build --
71+
${{ matrix.os == 'windows-latest' && '--test-concurrency=1' || '' }}
72+
${{ github.event_name == 'merge_group' && '--retry' || '' }}
7073
7174
# Gating job for branch protection.
7275
test-success:

0 commit comments

Comments
 (0)